-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing errorprone module for 4.5.0 in central as release was done with jdk 8 #2623
Comments
Ah ugh, yes that's a mistake. We will need to update our GitHub actions configuration to run the release job on JDK 11. Do you mind sending us a PR that updates the job matrix to skip the release on JDK 8 and runs it on JDK 11? |
Yes I can do so later tonight.
Sent from my Verizon, Samsung Galaxy smartphone
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Tim van der Lippe ***@***.***>
Sent: Wednesday, April 20, 2022 5:43:12 AM
To: mockito/mockito ***@***.***>
Cc: Jeremy Landis ***@***.***>; Author ***@***.***>
Subject: Re: [mockito/mockito] Missing errorprone module for 4.5.0 in central as release was done with jdk 8 (Issue #2623)
Ah ugh, yes that's a mistake. We will need to update our GitHub actions configuration to run the release job on JDK 11. Do you mind sending us a PR that updates the job matrix to skip the release on JDK 8 and runs it on JDK 11?
—
Reply to this email directly, view it on GitHub<#2623 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHODI2OAUAPYQ33GQXM6LTVF7GTBANCNFSM5T2UWYBQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
hazendaz
added a commit
to hazendaz/mockito
that referenced
this issue
Apr 21, 2022
1 task
TimvdLippe
pushed a commit
that referenced
this issue
Apr 21, 2022
Triggered one just now. |
https://repo1.maven.org/maven2/org/mockito/mockito-errorprone/4.5.1/ has been released 🎉 |
Thanks @TimvdLippe @raphw for quick turn around |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Error prone module is missing for 4.5.0 and not in the 4.5.0 bom. Looking at the source code changes and release action, it appears jdk 8 was used to release and its ignored unless jdk 11 is used. Can someone check?
The text was updated successfully, but these errors were encountered: