Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indent with spaces using spotless #1820

Merged
merged 1 commit into from Nov 7, 2019
Merged

Indent with spaces using spotless #1820

merged 1 commit into from Nov 7, 2019

Conversation

@TimvdLippe
Copy link
Contributor

TimvdLippe commented Nov 6, 2019

Discovered in #1818 that (if new contributors are unaware of our indentation with 4 spaces), spotless did not fix the formatting. indentWithSpaces(4) does just that and it actually found other formatting issues.

@TimvdLippe TimvdLippe requested review from mockitoguy and bric3 Nov 6, 2019
Copy link
Contributor

bric3 left a comment

Cool.
Actually while I think that fixing those is nice. I think spotless is not about well chained method (on the the dot).

@bric3
bric3 approved these changes Nov 7, 2019
@TimvdLippe

This comment has been minimized.

Copy link
Contributor Author

TimvdLippe commented Nov 7, 2019

Yes that is correct. I think at that point you need a formatter like google-java-formatter or eclipse-formatter to fix these kind of "aesthetics".

@TimvdLippe TimvdLippe merged commit 8f68572 into release/3.x Nov 7, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@TimvdLippe TimvdLippe deleted the indent-with-spaces branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.