Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade byte buddy to 1.10.3 #1828

Merged
merged 1 commit into from Nov 26, 2019
Merged

Conversation

@dmitry-timofeev
Copy link
Contributor

dmitry-timofeev commented Nov 26, 2019

Release notes: https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.10.3

Upgrading to the newer version in our project fixed inline mocks, broken with Java 13 (see #1827 and #1483 (comment)).

Hey,

Thanks for the contribution, this is awesome.
As you may have read, project members have somehow an opinionated view on what and how should be
Mockito, e.g. we don't want mockito to be a feature bloat.
There may be a thorough review, with feedback -> code change loop.

Which branch :

  • On mockito 3.x, make your pull request target release/3.x
  • On mockito 2.x, make your pull request target release/2.x (2.x is in maintenance mode)

This block can be removed
_Something wrong in the template fix it here .github/PULL_REQUEST_TEMPLATE.md

check list

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant
@TimvdLippe TimvdLippe merged commit 3dd936c into mockito:release/3.x Nov 26, 2019
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing d6cec39...140d301
Details
codecov/project 86.71% remains the same compared to d6cec39
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dmitry-timofeev dmitry-timofeev deleted the dmitry-timofeev:patch-1 branch Nov 26, 2019
pull bot added a commit to scope-demo/mockito that referenced this pull request Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.