Fixes #2007 : Downgrade objenesis version for mockito-android

[kozaxinan]

check list

• Read the contributing guide
• PR should be motivated, i.e. what does it fix, why, and if relevant how
• If possible / relevant include an example in the description, that could help all readers
  including project members to get a better picture of the change
• Avoid other runtime dependencies
• Meaningful commit history ; intention is important please rebase your commit history so that each
  commit is meaningful and help the people that will explore a change in 2 years
• The pull request follows coding style
• Mention Fixes #<issue number> in the description if relevant
• At least one commit should mention Fixes #<issue number> if relevant

Fixes #2007

After building, mockito android pom includes objenesis 2.6 while mockito-core has objenesis 3.1.

Locally build version is Tested with our internal project to verify fix.

  androidTestImplementation('com.nhaarman.mockitokotlin2:mockito-kotlin:x.y.z') {
    exclude group: 'org.mockito', module: 'mockito-core'
  }

pom of mockito-android.

<dependencies>
    <dependency>
      <groupId>org.mockito</groupId>
      <artifactId>mockito-core</artifactId>
      <version>3.5.8</version>
      <scope>compile</scope>
      <exclusions>
        <exclusion>
          <artifactId>objenesis</artifactId>
          <groupId>org.objenesis</groupId>
        </exclusion>
      </exclusions>
    </dependency>
    <dependency>
      <groupId>net.bytebuddy</groupId>
      <artifactId>byte-buddy-android</artifactId>
      <version>1.10.13</version>
      <scope>compile</scope>
    </dependency>
    <dependency>
      <groupId>org.objenesis</groupId>
      <artifactId>objenesis</artifactId>
      <version>2.6</version>
      <scope>compile</scope>
    </dependency>
  </dependencies>

Side note: I had problem with animal sniffer on release/3.x branch. I had to disable android api 24 signature check to compile the app.

org.mockito.internal.creation.bytebuddy.InlineByteBuddyMockMaker:507  Undefined reference (android-api-level-24-7.0_r2): java.lang.instrument.Instrumentation
org.mockito.internal.creation.bytebuddy.InlineByteBuddyMockMaker:507  Undefined reference (android-api-level-24-7.0_r2): boolean java.lang.instrument.Instrumentation.isModifiableClass(Class)

Breaking changes solutions for android modules

Solution 1

If you have motkito-kotlin with mockito-android, exclude mockito-core from mockito-kotlin.

        implementation("com.nhaarman.mockitokotlin2:mockito-kotlin:<version>") {
            exlcude group: "org.mockito", module: "mockito-core"
        }

Solution 2

Don't add mockito-core with mockito-android

Solution 3

Use dependency resolution

in root build.gradle

subprojects {
  configurations.configureEach {
    resolutionStrategy.eachDependency { details ->
      if (details.requested.group == 'org.objenesis') { 
        details.useVersion '2.6'
      }
    }
  }
}

[codecov-commenter]

Codecov Report

Merging #2024 into release/3.x will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release/3.x    #2024   +/-   ##
==============================================
  Coverage          84.88%   84.88%           
  Complexity          2703     2703           
==============================================
  Files                325      325           
  Lines               8198     8198           
  Branches             979      979           
==============================================
  Hits                6959     6959           
  Misses               968      968           
  Partials             271      271           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8007df7...8918202. Read the comment docs.

[kozaxinan]

Objenesis 2.6 version is now strictly defined in mockito-android. When mockito-core or mockito-kotlin is added as dependency, there will be version conflict for objenesis 2.6 and 3.1. For helping developer, because reason is added for strict version with suggestion for how to continue.

Could not resolve org.objenesis:objenesis:3.1.
     Required by:
         project :app > org.mockito:mockito-android:3.5.8 > org.mockito:mockito-core:3.5.8
      > Cannot find a version of 'org.objenesis:objenesis' that satisfies the version constraints:
           Dependency path 'is24-android:app:unspecified' --> 'org.mockito:mockito-android:3.5.8' --> 'org.objenesis:objenesis:{strictly 2.6}' because of the following reason: 
        --------------------------------------\     /-------------------------------------
        ---------------------------------------\   /--------------------------------------
        ----------------------------------------\ /---------------------------------------
        -----------------------------------------V----------------------------------------
        Mockito core uses Objenesis 3.x and Objenesis 3.x does not work with android api 25 and below.
        If you have mockito-core dependency with mockito-android, remove mockito-core.
        If you have mockito-kotlin, exclude mockito-core.
        implementation("com.nhaarman.mockitokotlin2:mockito-kotlin") {
            exclude group: "org.mockito", module: "mockito-core"
        }
        For more information please check;
            https://github.com/mockito/mockito/pull/2024
            https://github.com/mockito/mockito/pull/2007
        -----------------------------------------A----------------------------------------
        ----------------------------------------/ \---------------------------------------
        ---------------------------------------/   \--------------------------------------
        --------------------------------------/     \-------------------------------------
        
           Dependency path 'is24-android:app:unspecified' --> 'org.mockito:mockito-android:3.5.8' --> 'org.mockito:mockito-core:3.5.8' --> 'org.objenesis:objenesis:3.1'

[TimvdLippe]

This would work for me. @raphw WDYT?

[raphw]

Looks good to me, should we maybe still avoid the ASCII art? This can be difficult to read in some CI environments, I think the message by itself should be sufficient?

[kozaxinan]

I added asci art because when you have multiple conflicts, explanation text is between gradle messages. It might not be clear enough for inexperienced dev. That is just an assumption.

Please feel free to adjust if it is needed.

[TimvdLippe]

WDYT about this?

[madisoncfallin]

Hey folks! I hate to beat a merged horse, but I'm having a ton of trouble building locally and it seems to be related to this issue. Can anyone offer me some pointers?

https://stackoverflow.com/questions/64341381/trouble-setting-up-mockito-for-local-development