Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use single version for strictly in mockito-android #2053

Merged
merged 1 commit into from Sep 24, 2020

Conversation

kozaxinan
Copy link
Contributor

@kozaxinan kozaxinan commented Sep 24, 2020

check list

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

Fixes #2007

In #2024, code review suggested to use strictly '[2.6, 3.1[' instead if strictly '2.6'. Comment
Apparently I failed to test that suggestion and it broke the fix in #2007.

Using strictly '2.6' works as expected. It fails the objenesis resolution and suggest to exclude mockito-core from mockito-kotlin.

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2020

Codecov Report

Merging #2053 into release/3.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release/3.x    #2053   +/-   ##
==============================================
  Coverage          84.90%   84.90%           
  Complexity          2704     2704           
==============================================
  Files                325      325           
  Lines               8206     8206           
  Branches             979      979           
==============================================
  Hits                6967     6967           
  Misses               968      968           
  Partials             271      271           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e338d91...8bebc5f. Read the comment docs.

Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Thanks unfortunate, but understood why it doesn't work. Thanks for verifying and fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants