Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thread race condition #2248

Merged
merged 2 commits into from Apr 5, 2021
Merged

Fix thread race condition #2248

merged 2 commits into from Apr 5, 2021

Conversation

@TimvdLippe
Copy link
Contributor

@TimvdLippe TimvdLippe commented Mar 31, 2021

Discovered internally at Google. The culprit was a thread race condition
around the usage of usedAt, which could race between setting the field
and retrieving it.

Discovered internally at Google. The culprit was a thread race condition
around the usage of usedAt, which could race between setting the field
and retrieving it.
@TimvdLippe TimvdLippe requested a review from raphw Mar 31, 2021
@TimvdLippe
Copy link
Contributor Author

@TimvdLippe TimvdLippe commented Apr 5, 2021

Reviewed internally at Google. Assuming no objections on this PR, so merging.

@TimvdLippe TimvdLippe merged commit 08a2e76 into release/3.x Apr 5, 2021
7 checks passed
7 checks passed
@github-actions
build (8, mock-maker-default)
Details
@github-actions
build (8, mock-maker-inline)
Details
@github-actions
build (11, mock-maker-default)
Details
@github-actions
build (11, mock-maker-inline)
Details
@github-actions
build (15, mock-maker-default)
Details
@github-actions
build (15, mock-maker-inline)
Details
@github-actions
release
Details
@TimvdLippe TimvdLippe deleted the fix-thread-race-condition branch Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant