Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2007 : Update objenesis dep to 3.2 #2249

Conversation

@PaulKlauser
Copy link
Contributor

@PaulKlauser PaulKlauser commented Mar 31, 2021

Allows for building android instrumentation tests with minsdk < 26

Checklist

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant
Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

We will also need to update android.gradle to use the latest version of objenesis again. E.g. we would need to effectively revert #2024 so that both android.gradle and the main project use the same version of objenesis.

@PaulKlauser PaulKlauser force-pushed the PaulKlauser:bugfix/2007-objenesis-fails-android-instrumentation branch from 34d7eda to e05fdd6 Mar 31, 2021
Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

This LGTM! Just to confirm: have you locally applied these changes and ran your Android tests on SDK <26 and confirmed they are indeed running as expected? I would like to avoid publishing a breaking release once again.

@PaulKlauser
Copy link
Contributor Author

@PaulKlauser PaulKlauser commented Mar 31, 2021

Good call, just published the artifacts locally and gave it a go. Everything looks good, building and running tests on API 24!

@TimvdLippe
Copy link
Contributor

@TimvdLippe TimvdLippe commented Mar 31, 2021

Great, thanks for the confirmation!

@TimvdLippe TimvdLippe merged commit ec34188 into mockito:release/3.x Mar 31, 2021
7 checks passed
7 checks passed
@github-actions
build (8, mock-maker-default)
Details
@github-actions
build (8, mock-maker-inline)
Details
@github-actions
build (11, mock-maker-default)
Details
@github-actions
build (11, mock-maker-inline)
Details
@github-actions
build (15, mock-maker-default)
Details
@github-actions
build (15, mock-maker-inline)
Details
@github-actions
release
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants