Introduce a BOM for Mockito's artifacts (closes #2321) #2323
Conversation
There was a problem hiding this comment.
The BOM in #2321 (comment) lists all versions with SNAPSHOT. Instead, I think we should list the explicit versions. We currently do that with Shipkit on tags: https://github.com/shipkit/shipkit-auto-version#usage-based-on-annotated-tag
Can we make sure that the explicit versions work with our GitHub actions integration? I am not actually sure how that would look like, but I think you should be able to run ./gradlew publishToMavenLocal -Pversion=3.12.0 and see what the result is.
realdadfish
force-pushed
the
bill-of-materials
branch
from
7b5d9e8
to
bc05a68
Compare
|
@mockitoguy This looks fine to me, but do we need to create this new artifact in Maven Central or does that work automatically? |
|
Hey @TimvdLippe, what's the status of this? :-) |
|
This is still pending a review of @mockitoguy per #2323 (comment) |
|
I am inclined to merge this PR as-is and see if we run into any issues when we release to Maven Central. We might have to revert the PR then or do a follow-up to get things to work properly. Therefore, merging it 😄 |
…o#2323) Co-authored-by: Thomas Keller <thomas.keller-extern@deutschebahn.com>
See discussion in #2321