Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new CodeCov uploader #2447

Merged
merged 1 commit into from Oct 17, 2021
Merged

Use new CodeCov uploader #2447

merged 1 commit into from Oct 17, 2021

Conversation

@TimvdLippe
Copy link
Contributor

@TimvdLippe TimvdLippe commented Oct 17, 2021

Per https://about.codecov.io/blog/introducing-codecovs-new-uploader/ the Bash uploader has been deprecated.
The Bash uploader will randomly stop working, meaning we won't be able to inspect our code coverage reports.

Instead, we should be using the new uploader.
We should also check its integrity to avoid a repeat of the security vulnerability in the Bash uploader.

Per https://about.codecov.io/blog/introducing-codecovs-new-uploader/ the Bash uploader has been deprecated.
The Bash uploader will randomly stop working, meaning we won't be able to inspect our code coverage reports.

Instead, we should be using the new uploader.
We should also check its integrity to avoid a repeat of the security vulnerability in the Bash uploader.
@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Oct 17, 2021

Codecov Report

Merging #2447 (c7fa523) into main (2697478) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #2447   +/-   ##
=========================================
  Coverage     86.45%   86.45%           
  Complexity     2762     2762           
=========================================
  Files           318      318           
  Lines          8304     8304           
  Branches       1016     1016           
=========================================
  Hits           7179     7179           
  Misses          852      852           
  Partials        273      273           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2697478...c7fa523. Read the comment docs.

@TimvdLippe TimvdLippe merged commit 29eb4ee into main Oct 17, 2021
7 checks passed
@TimvdLippe TimvdLippe deleted the TimvdLippe-patch-3 branch Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants