Issue 2544 #2545
Merged
Issue 2544 #2545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tructionWithAnswer(). If you build a mockConstructionWithAnswer with more than 1 additionalAnswers there was a logic error whereby the method would return the wrong value when making the second last invocation. It would accidentally think it's at the end an only return the last answer, never returning the second last answer when it should. The changes I made to ConstructionMockTest.java now exercises this condition.
…tructionWithAnswer(). If you build a mockConstructionWithAnswer with more than 1 additionalAnswers there was a logic error whereby the method would return the wrong value when making the second last invocation. It would accidentally think it's at the end an only return the last answer, never returning the second last answer when it should. The changes I made to ConstructionMockTest.java now exercises this condition.
TimvdLippe
requested changes
Jan 18, 2022
| @@ -50,10 +50,11 @@ public void testConstructionMockDefaultAnswer() { | |||
|
|
|||
| @Test | |||
| public void testConstructionMockDefaultAnswerMultiple() { | |||
There was a problem hiding this comment.
Can we retain the original test (e.g. 2 invocation definitions and invoking it 3 times) and instead add a new regression test which is this new format? That way we ensure that both scenarios still work, thanks!
I restored testConstructionMockDefaultAnswer() in ConstructionMockTest to it's original 2-invocation form. I added new test, testConstructionMockDefaultAnswerMultipleMoreThanTwo() to demonstrate the code is now fixed when more than 2 invocations are in place.
RomaZe
added a commit
to arenadata/pxf
that referenced
this pull request
Jul 25, 2023
Spring Boot Version 2.4.3 adds org.mockito package with version 3.6.8. There is a bug with this version: mockito/mockito#2545 So we need to keep additional invocation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue 2544.
Mockito.mockConstructionWithAnswer() has a bug when there are more than 2 invocations possible.
If you run the ConstructionMockTest.testConstructionMocDefaultAnswerMultiple() as this:
It works fine.
But if you change it to this:
It will fail when trying to assert
qux. It's because there is an error in the conditional logic in theelse if (context.getCount() >= additionalAnswers.length). It should be>not>=.