-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate ListUtil and Fields classes #2593
Deprecate ListUtil and Fields classes #2593
Conversation
797bbde
to
84743b4
Compare
Codecov Report
@@ Coverage Diff @@
## main #2593 +/- ##
============================================
- Coverage 86.65% 86.57% -0.08%
- Complexity 2795 2804 +9
============================================
Files 321 321
Lines 8368 8357 -11
Branches 1024 1020 -4
============================================
- Hits 7251 7235 -16
- Misses 849 854 +5
Partials 268 268
Continue to review full report at Codecov.
|
84743b4
to
4d957e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With "Android users", I meant those that are using Mockito on older versions of Android that does not support lambda's and all. However, these projects can desugar, which might solve the problem.
Therefore, if we are still compatible with Android SDK 24 (I believe that's the version we use), I think we can merge this as-is. Let's see what CI says.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like CI is happy, so we can make this change after all. Thanks for submitting this again! Only a couple of small comments.
src/main/java/org/mockito/internal/invocation/InvocationsFinder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/mockito/internal/util/collections/ListUtil.java
Outdated
Show resolved
Hide resolved
4d957e4
to
97f4841
Compare
97f4841
to
b58eeb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting back to us! Yes, this is a great cleanup and the Stream usages read a lot cleaner than we had before. Merging 🎉
Relates to #1926.