-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible fix #2765: Add task to download package-list file from java as element-list #2766
Possible fix #2765: Add task to download package-list file from java as element-list #2766
Conversation
…/api/package-list inside build dir as javase-6-docs/element-list, move javase/6/docs from links to linksOffline
hey @TimvdLippe, please check if this could a solution for #2765 |
Per this Java 8 build is going after |
Codecov ReportBase: 86.18% // Head: 86.18% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2766 +/- ##
=========================================
Coverage 86.18% 86.18%
Complexity 2831 2831
=========================================
Files 320 320
Lines 8583 8583
Branches 1058 1058
=========================================
Hits 7397 7397
Misses 905 905
Partials 281 281 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, glad that works! A couple of nits and let's make sure the artifact is verified with a shasum to prevent malicious content to be downloaded.
…ile for java 8 and 9+
…/java-8-docs dir, replace download tasks by a copy folder one
… directly to gradle/mockito-core/java-8-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The smallest fixes are most of the times the best ones 👍 Thanks for the work! Greatly appreciated 😄
I think these changes could a fix, or at least part of, for the issue #2765.
Checklist
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>
in the description if relevantFixes #<issue number>
if relevant