Avoids clearing stale weak entries from critical code segments. #2780
Conversation
…reduces the propability of checking for mocked from from the mock-checking code what can lead to infinitive loops.
|
Is it possible to write a test for this or is that infeasible? |
|
I would assume that it already fails when building on Java 19 without this fix. |
|
@TimvdLippe can confirm this fixes the deadlocking issues when I build this PR locally, versus 4.8.1 which immediately deadlocks for me. |
To verify that #2780 will resolve running on Java 19
|
I wanted to verify that master on Java 19 is broken (#2788) but discovered we need Gradle 7.6 for that. Not sure if we should wait for that, or release this without a regression test? |
|
I think we can just release this. @ascopes - could you confirm that this branch fixes your issue? |
|
@raphw I ran the tests 20 times over with it on Java 19 and saw no problems... Without the fix it was hanging within the first or second repeat. Looks fixed to me! |
|
Thanks for fixing this! Is there a potential date for when this will be released, out of curiosity? |
|
@ascopes 4.9.0 will be published today: https://github.com/mockito/mockito/releases/tag/v4.9.0 |
|
@TimvdLippe thats great, thank you! |
This reduces the probability of checking for mocked from from the mock-checking code what can lead to infinitive loops. Fixes #2767.