OSGI bundle problem - correct version specification syntax for bytebuddy #679
Conversation
Proposed fix for mockito#678: Use double quotes around version specification for Byte Buddy dependencies. The version for Objenesis dependencies is already specified correctly.
Current coverage is 87.23% (diff: 100%)@@ master #679 diff @@
==========================================
Files 272 272
Lines 5476 5476
Methods 0 0
Messages 0 0
Branches 901 901
==========================================
+ Hits 4776 4777 +1
Misses 508 508
+ Partials 192 191 -1
|
| @@ -16,7 +16,7 @@ afterEvaluate { | |||
| "org.mockito.*;version=${version}" | |||
|
|
|||
| instruction 'Import-Package', | |||
| 'net.bytebuddy.*;version=[1.4.26,2.0)', | |||
| 'net.bytebuddy.*;version="[1.4.26,2.0)"', | |||
There was a problem hiding this comment.
@mgrafl
this can be reduced to [1.4.26) which has an inclusive lower limit and an exclusive upper limit, denoting version 1.4.26 and any version after this, up to, but not including, version 2.0.0.
There was a problem hiding this comment.
I'd rather not allow an infinite boundary. 2.0 is a major version with probable API changes.
There was a problem hiding this comment.
@bric3 nobody want's to introduce an infinite boundary, i requested to use the short form
There was a problem hiding this comment.
Yes but the OSGI range specification do say that [1.4.26) is equal to [1.4.26,∞) ;)
An “unbounded” version range, such as 1.2, which denotes version 1.2 and all later versions.
|
@mgrafl could you rebase your change on top of |
|
@bric3, Unfortunately, I cannot rebase the pull request from the website without write access to the repo. |
|
@mgrafl you can from your own repository ;) If you want I can cherry pick your commit. |
|
@bric3 yes, please do cherry pick it. Thanks. |
|
Fixed via 615f7b4 on |
mockitoguy
changed the title
Proposed fix for #678:
Use double quotes around version specification for Byte Buddy dependencies.
The version for Objenesis dependencies is already specified correctly.