This repository has been archived by the owner on Jan 18, 2021. It is now read-only.
minor cleanup #568
Merged
minor cleanup #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
epeee
commented
Nov 14, 2017
epeee
commented
- get rid of unused imports
- make use of IOUtil.close
- get rid of output variable
mockitoguy
approved these changes
Nov 15, 2017
| fos.write(buf, 0, n); | ||
| } | ||
| } finally { | ||
| close(fos); |
There was a problem hiding this comment.
If close() fails with IOException, we are losing the original exception.
Perhaps we need 2 methods: "close()" and "closeQuietly()".
I know that this problem was present before... since you are changing the code now, let's improve it :)
| } catch (IOException e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| close(input); |
There was a problem hiding this comment.
This can also swallow the original exception.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.