Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub release notes encoding #820

Merged
merged 2 commits into from Apr 10, 2019

Conversation

Projects
None yet
3 participants
@mstachniuk
Copy link
Contributor

mstachniuk commented Apr 4, 2019

Fix #813

@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #820 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #820      +/-   ##
============================================
- Coverage     76.91%   76.89%   -0.02%     
- Complexity     1227     1236       +9     
============================================
  Files           219      219              
  Lines          4475     4476       +1     
  Branches        336      334       -2     
============================================
  Hits           3442     3442              
  Misses          922      922              
- Partials        111      112       +1
Impacted Files Coverage Δ Complexity Δ
...in/groovy/org/shipkit/internal/util/GitHubApi.java 71.42% <100%> (ø) 5 <0> (ø) ⬇️
.../shipkit/internal/gradle/release/TravisPlugin.java 78.26% <0%> (-11.74%) 3% <0%> (-2%)
...ipkit/internal/gradle/exec/ExecCommandFactory.java 93.75% <0%> (+3.75%) 24% <0%> (+11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20416a2...51e332b. Read the comment docs.

@epeee
Copy link
Member

epeee left a comment

Thank you!
pls have a look at my comments.

wr.flush();
}
OutputStream os = conn.getOutputStream();
os.write(body.get().getBytes(Charset.forName("UTF-8")));

This comment has been minimized.

Copy link
@epeee

epeee Apr 5, 2019

Member

let's use StandardCharsets.UTF_8 here

wr.writeBytes(body.get());
wr.flush();
}
OutputStream os = conn.getOutputStream();

This comment has been minimized.

Copy link
@epeee

epeee Apr 5, 2019

Member

Let's re-add the try-with-resources here

@@ -78,3 +78,5 @@ private String call(String method, HttpsURLConnection conn) throws IOException {
}
}
}
//https://api.github.com/repos/mstachniuk/mockito/releases

This comment has been minimized.

Copy link
@epeee

epeee Apr 5, 2019

Member

let's also remove this comment or add it as a more general one to the doc if needed

@mockitoguy
Copy link
Member

mockitoguy left a comment

+1 to @epeee's feedback.

@epeee

epeee approved these changes Apr 10, 2019

@mstachniuk mstachniuk merged commit 4c01bfa into master Apr 10, 2019

4 checks passed

codecov/patch 100% of diff hit (target 76.91%)
Details
codecov/project Absolute coverage decreased by -0.01% but relative coverage increased by +23.08% compared to 20416a2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mstachniuk mstachniuk deleted the release-notes-encoding branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.