Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build logic improvements #840

Merged
merged 1 commit into from Jul 8, 2022
Merged

Build logic improvements #840

merged 1 commit into from Jul 8, 2022

Conversation

c00ler
Copy link
Contributor

@c00ler c00ler commented Jul 8, 2022

This Pull Request proposes small improvements to the build script logic aiming to improve performance and maintainability.

Changes:

  • Upgrade gradle to the latest stable version (./gradlew wrapper --gradle-version 7.4.2)
  • Fix deprecations
  • Enable parallel execution
  • Dump new API declarations

Suggestions before changes https://scans.gradle.com/s/3ffplgunxqwka/performance/suggestions and after https://scans.gradle.com/s/5ekwl2ajlbtiw/performance/suggestions

Also, I found out that in some circumstances :mockk-common:compileTestKotlinCommon task might not be cacheable. Unfortunately, there is nothing that can be done about it at the moment. I've created a ticket for the kotlin team: KT-53110

* Overwrite api declarations

* Configure GE instance

* Enable parallel tasks execution

* Upgrade gradle version

* Fix deprecations

* Fix build

* Use TaskProvider api for task definition

* Remove GE instance
dependsOn compileJava
dependsOn compileKotlin
from "${sourceSets.main.java.outputDir}/io/mockk/proxy/jvm/dispatcher"
into "${sourceSets.main.java.outputDir}/io/mockk/proxy/jvm/dispatcher"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outputDir is deprecated

@@ -7,8 +7,8 @@ jacoco {
afterEvaluate {
jacocoTestReport {
reports {
xml.enabled = true
html.enabled = true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enabled is deprecated

@Raibaz
Copy link
Collaborator

Raibaz commented Jul 8, 2022

Thanks a lot for sending this through!

@Raibaz Raibaz merged commit ebb943a into mockk:master Jul 8, 2022
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants