Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android Instrumentation dispatcher.jar inclusion #899

Merged
merged 1 commit into from Aug 25, 2022

Conversation

aSemy
Copy link
Contributor

@aSemy aSemy commented Aug 24, 2022

Fixes #894

My take on #895 - credit to @kubode for identifying the problem and showing how to check it.

What do you think @kubode?

It also includes using the Gradle task output - this helps with Gradle task optimisation. Wrapping the task in a lambda prevents the NPE.

The issue in this comment is also resolved #895 (comment)

image

@aSemy aSemy marked this pull request as draft August 24, 2022 21:30
@aSemy aSemy marked this pull request as ready for review August 24, 2022 21:59
@kubode
Copy link
Contributor

kubode commented Aug 25, 2022

👀

I think it's better than before because it is less buggy and less hard-coding 👍

@Raibaz
Copy link
Collaborator

Raibaz commented Aug 25, 2022

Nice, thanks!

@Raibaz Raibaz merged commit fe36b92 into mockk:master Aug 25, 2022
21 checks passed
@kubode
Copy link
Contributor

kubode commented Aug 25, 2022

@Raibaz
It seems that #895 was unintentionally closed.
#895 still contains an unfixed issue. (See #895 (comment))
So could you please re-open it?

@Raibaz
Copy link
Collaborator

Raibaz commented Aug 25, 2022

Sure, done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mockk-android:1.12.7 always fails with 'dispatcher.jar' not found
3 participants