Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try reverting Android minSdk to 21 #901

Merged
merged 3 commits into from Aug 25, 2022
Merged

Conversation

aSemy
Copy link
Contributor

@aSemy aSemy commented Aug 24, 2022

Might resolve #893.

Changing minSdk was done in PR #863 , which was a modified PR based on #829. I don't know if the minSdk is required to be 26 - it doesn't seem like 23 has any problems.

@Raibaz
Copy link
Collaborator

Raibaz commented Aug 25, 2022

Can you try setting minSdkVersion to 21 for additional backwards compatibility?

@aSemy aSemy changed the title try reverting Android minSdk to 23 try reverting Android minSdk to ~23~ 21 Aug 25, 2022
@aSemy aSemy changed the title try reverting Android minSdk to ~23~ 21 try reverting Android minSdk to 21 Aug 25, 2022
@SimonMarquis
Copy link
Contributor

There are no compilation errors/warnings on my end when downgrading to minSdk = 21 👍

@SimonMarquis
Copy link
Contributor

SimonMarquis commented Aug 25, 2022

My bad, there is at least one warning: Cast from ArraySet to Set requires API level 23 (current min is 21) for

Set<Object> mocks = new ArraySet<>(adapters.size());

and

Set<Entry<Object, MockKInvocationHandler>> entries = new ArraySet<>(
adapters.size());

And another two for the constructor calls: Call requires API level 23 (current min is 21): new android.util.ArraySet

@Raibaz Raibaz merged commit b72cf14 into mockk:master Aug 25, 2022
20 checks passed
@aSemy aSemy deleted the fix/android_minsdk_23 branch August 25, 2022 22:26
@aSemy
Copy link
Contributor Author

aSemy commented Aug 25, 2022

In this case the warnings aren't a problem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to 1.12.7 bumps minSdkVersion to 26 on Android
3 participants