Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the official Gradle GHA #914

Merged
merged 7 commits into from Sep 5, 2022

Conversation

aSemy
Copy link
Contributor

@aSemy aSemy commented Sep 4, 2022

Use the official Gradle GitHub Action https://github.com/marketplace/actions/gradle-build-action

Two reasons:

  1. I've noticed that the GitHub actions aren't always cached, and thus they take longer than necessary
  2. Less configuration is needed


- name: Run tests with Gradle
run: |
./gradlew check
Copy link
Contributor Author

@aSemy aSemy Sep 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also changed ./gradlew test to ./gradlew check, because I noticed that the API dumps are not up to date. The apiCheck task will run if the check task runs, not test.

aSemy added a commit to aSemy/mockk that referenced this pull request Sep 4, 2022
@aSemy aSemy marked this pull request as ready for review Sep 4, 2022
@Raibaz
Copy link
Collaborator

Raibaz commented Sep 5, 2022

Thanks a lot, especially for spotting that we were doing gradle test rather than gradle check!

@Raibaz Raibaz merged commit cede3b1 into mockk:master Sep 5, 2022
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants