Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow resizing route column #104

Closed
DevRyanDonahue opened this issue Mar 22, 2019 · 7 comments
Closed

Allow resizing route column #104

DevRyanDonahue opened this issue Mar 22, 2019 · 7 comments
Assignees
Labels
feature New feature request
Milestone

Comments

@DevRyanDonahue
Copy link

Is your feature request related to a problem? Please describe.
When the routes in my environment become long, it can become impossible to differentiate which is which based on the routes list. The last of the text is truncated so I have to navigate to each route to see what it is

Describe the solution you'd like
Allowing resizing of this column would likely be the best solution. A hover tooltip on route items would be a next best.

Describe alternatives you've considered
Truncating at beginning of text or the middle, but they could still hold valuable information that making the column bigger could still display.

Additional context
Add any other context or screenshots about the feature request here.

@axc450
Copy link
Contributor

axc450 commented Apr 6, 2019

I can look into adding this, but it might not make it into the next release

@sotcha
Copy link
Contributor

sotcha commented Mar 4, 2020

Hi, I have a close to final implementation for this feature. Do you want to get a PR for this ?

@255kb
Copy link
Member

255kb commented Mar 4, 2020

Hi @sotcha . All contributions are welcome!
However, I would like to discuss the implementation with you first. How do you plan to do this? Like a traditional resize (mouse click on the border, hold, move, release click)? As it may leads to lots of repaint, because of column resize, how are the performances?
Also, On the master branch (upcoming version), I worked on a collapsible environments menu with lots of refactoring. You absolutely must start your work from this branch :)

@sotcha
Copy link
Contributor

sotcha commented Mar 4, 2020

Hi @255kb , yes I forked from the master branch.

Well, I created a directive which works (as you described like the traditional resize) :

  • Start when onMouseClick on the directive
  • Register mousemove and mouseup listener on the body
  • Release on mouse up

The performance seems to be OK, at least on my laptop.

I have a draft commit here :
https://github.com/sotcha/mockoon/tree/feature/allow-resizing-route-column-%23104

Have a look if you want.

image

resize-mockoon

@255kb
Copy link
Member

255kb commented Mar 5, 2020

This looks great! Feel free to open the PR. I will try to review it in the coming days/weeks. Anyway, it can make it for the next release. I have still things I am working on and bugs I want to solve for 1.8.0.

@255kb 255kb added this to the v1.8.0 milestone Mar 5, 2020
@sotcha
Copy link
Contributor

sotcha commented Mar 8, 2020

Hi @255kb , what do you think about adding the same functionality into the environment logs column.

Something like this
image

Also as I can see into the description it is we would like to add a hover tooltip over the url name

image

Should I add these to this PR?

sotcha added a commit to sotcha/mockoon that referenced this issue Mar 8, 2020
sotcha added a commit to sotcha/mockoon that referenced this issue Mar 8, 2020
@255kb
Copy link
Member

255kb commented Mar 8, 2020

I would say it's a great idea and I think it was requested already. If you don't mind, I would prefer that you open a new issue and PR so it's easier for me to test and review 🤗 (unless it only adds few things, then just push it with your initial PR)

sotcha added a commit to sotcha/mockoon that referenced this issue Mar 9, 2020
sotcha added a commit to sotcha/mockoon that referenced this issue Mar 9, 2020
sotcha added a commit to sotcha/mockoon that referenced this issue Mar 22, 2020
- Save last column width to settings
@255kb 255kb removed this from the v1.8.0 milestone Mar 30, 2020
@255kb 255kb added this to the next milestone Apr 22, 2020
sotcha added a commit to sotcha/mockoon that referenced this issue May 2, 2020
…ased on a window size factor

Fix PR comments
sotcha added a commit to sotcha/mockoon that referenced this issue May 2, 2020
…ased on a window size factor

Fix PR comments
sotcha added a commit to sotcha/mockoon that referenced this issue May 2, 2020
…ased on a window size factor

Fix PR comments
@255kb 255kb closed this as completed in 50983d8 May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request
Projects
Archived in project
Development

No branches or pull requests

4 participants