Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODCLUSTER-561 Upgrade maven-war-plugin to version compatible with JDK 9 #257

Merged
merged 2 commits into from Jun 1, 2017
Merged

MODCLUSTER-561 Upgrade maven-war-plugin to version compatible with JDK 9 #257

merged 2 commits into from Jun 1, 2017

Conversation

rhusar
Copy link
Member

@rhusar rhusar commented May 30, 2017

@Karm Karm self-assigned this Jun 1, 2017
@Karm Karm merged commit 3c64fb4 into modcluster:master Jun 1, 2017
@Karm
Copy link
Member

Karm commented Jun 1, 2017

Merged 🙈

@rhusar
Copy link
Member Author

rhusar commented Jun 1, 2017

@Karm bit of a premature merge. All fixes required for support branches need to be merged before upstream can be merged. Since we need to support JDK9 for 1.3 branch, it needs to be merged first.

@rhusar
Copy link
Member Author

rhusar commented Jun 1, 2017

Opened #259 for 1.3.

@rhusar
Copy link
Member Author

rhusar commented Jun 1, 2017

Also, Jiras need to be resolved upon merge.

@rhusar rhusar deleted the MODCLUSTER-561 branch June 1, 2017 13:00
@rhusar
Copy link
Member Author

rhusar commented Jun 1, 2017

Ok, the mess is cleaned up now.

@Karm
Copy link
Member

Karm commented Jun 1, 2017

@rhusar O.K. THX.

This caught my eye though:

Since we need to support JDK9 for 1.3 branch

Hmm, do we? I was under the impression we were going to release 2.0.0.Final for

  • Tomcat 8.5
  • Wildfly 11.something

but from your comment, it seems we are stuck on 1.3.x until

  • Tomcat 9
  • Wildfly 12

Could you elaborate more? Perhaps in an article on JBoss forum?

@Karm
Copy link
Member

Karm commented Jun 1, 2017

@rhusar

Ad

All fixes required for support branches need to be merged

Fix version/s field needs updating I guess:
https://issues.jboss.org/browse/MODCLUSTER-586

@rhusar
Copy link
Member Author

rhusar commented Jun 1, 2017

Fix version/s field needs updating I guess:
https://issues.jboss.org/browse/MODCLUSTER-586

No, this was not backported as its not needed

@rhusar
Copy link
Member Author

rhusar commented Jun 1, 2017

Hmm, do we? I was under the impression we were going to release 2.0.0.Final for [..]

I am afraid we don't have a concrete timeline yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants