[MODCLUSTER-414] Fix compilation warnings in the native part (mod_advertise+mod_manager) #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vertise part: * line 89: unused variable (ma_listen_socket) * line 178: string literals need to be compared using strcmp() * line 657: wrong format for port %l but port is defined as int * line 734: wrong format with precision loss, type long int but printed as %d
…nager part: * fix several problems when uninitialized value was returned
|
Triggering build using a merge of 2d9d960 on branch master: |
|
Build 66 outcome was SUCCESS using a merge of 2d9d960 on branch master: |
rhusar
changed the title
|
@jfclere Ping, this could use your review and merge :-) |
jfclere
added a commit
that referenced
this pull request
Sep 4, 2014
[MODCLUSTER-414] Fix compilation warnings in the native part (mod_advertise+mod_manager)
| s->storage->ap_slotmem_free(s->slotmem, context->id, context); | ||
| else { | ||
| if (context->id) { | ||
| rv = s->storage->ap_slotmem_free(s->slotmem, context->id, context); |
There was a problem hiding this comment.
Just checked -- return value of this function call is never used in the code so it could not have caused a problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/MODCLUSTER-414
mod_advertise part:
mod_manager part: