Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a simple heatmap based on retentionHeatmap that can be used for any 2-label data #42

Merged
merged 2 commits into from Nov 1, 2019

Conversation

loufranco
Copy link
Contributor

@loufranco loufranco commented Oct 24, 2019

I based this visualization on the retention heat map, but simplified it so I could use it on my more generic 2-label data.

I don't know what you use to minimize, but I could add a commit with the correct minimizations if you tell me how to do it.

@loufranco
Copy link
Contributor Author

@loufranco loufranco commented Nov 1, 2019

@leqilong What is the best way to move this PR forward? I can add the min.js if you tell me how -- I could make any other changes you want.

I'm using this now in a mode report and it would be nice if I could just include it (which requires it to be hosted by mode)

@leqilong
Copy link
Contributor

@leqilong leqilong commented Nov 1, 2019

Hi @loufranco, sorry for missing your PR. We use uglifyjs to minimize the alamode.js file. You can use this command to do so:
uglifyjs --compress --mangle -- alamode.js

As for the alamode.css file, we use csso. And the command is:
csso alamode.css --output alamode.min.css

@leqilong leqilong requested review from leqilong and removed request for leqilong Nov 1, 2019
@loufranco
Copy link
Contributor Author

@loufranco loufranco commented Nov 1, 2019

Ok @leqilong, I minified. Let me know if there's anything else I need to do.

@leqilong leqilong merged commit ba1da84 into mode:master Nov 1, 2019
@leqilong
Copy link
Contributor

@leqilong leqilong commented Nov 1, 2019

@loufranco Thanks. I've deployed your changes. You should be able to start using it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants