jsonschema: marshal to bools #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marshal the empty schema to true, and its negation to false. This is a breaking behavior change, but a properly written consumer of JSON Schema will not notice.
samthanawalla
previously approved these changes
Aug 6, 2025
findleyr
reviewed
Aug 6, 2025
| {`true`, `{}`}, // boolean schemas become object schemas | ||
| {`false`, `{"not":{}}`}, | ||
| {`{"type":"", "enum":null}`, `{}`}, // empty fields are omitted | ||
| {`true`, `true`}, |
Contributor
There was a problem hiding this comment.
Do we want to make both of these changes, or just 'false'?
I've not seen many examples of a schema being 'true', but have seen examples of a schema being 'false'.
Contributor
Author
There was a problem hiding this comment.
It seems odd to do one without the other.
findleyr
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marshal the empty schema to true, and its negation to false.
This is technically a breaking behavior change, but a properly written consumer of JSON Schema will not notice.
For #244.
Fixes #230.