Add SEP-1034 conformance test support to everything-server #1604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new tool `test_elicitation_sep1034_defaults` that demonstrates elicitation with default values for all JSON Schema primitive types (string, integer, number, enum, boolean) as specified in SEP-1034. This enables conformance testing of SEP-1034 against the Python SDK implementation. All 5 conformance checks pass: - String default value support - Integer default value support - Number default value support - Enum default value support - Boolean default value support (regression test) The implementation uses Pydantic Field defaults which are automatically included in the generated JSON schema passed to the elicitation request.
felixweinberger
force-pushed
the
fweinberger/sep-1034-conformance
branch
from
0a894ae to
d7d6376
Compare
maxisbey
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds SEP-1034 conformance test support to the everything-server by implementing a new tool that demonstrates elicitation with default values for all JSON Schema primitive types.
Motivation and Context
This PR enables conformance testing of SEP-1034 against the Python SDK implementation. SEP-1034 extends MCP elicitation support to include default values for all primitive types (string, integer, number, enum, boolean), not just booleans.
How Has This Been Tested?
All 5 SEP-1034 conformance checks pass when running the conformance test suite against the everything-server:
Ran conformance tests:
Breaking Changes
No
Types of changes
Checklist
Additional context
The implementation leverages Pydantic Field defaults which automatically generate the correct JSON schema with
defaultfields for the elicitation request. This aligns with how the TypeScript SDK implements SEP-1034.