Skip empty SSE data to avoid parsing errors #1670
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip empty SSE data events (keep-alive pings) in the streamable HTTP client to avoid JSON parsing errors.
Motivation and Context
SSE servers may send empty data lines as keep-alive pings. The current implementation attempts to parse all SSE data as JSON, which fails for empty data, causing connection errors.
How Has This Been Tested?
_handle_sse_eventwith empty SSE dataBreaking Changes
None
Types of changes
Checklist
Additional context
This is a defensive fix to handle keep-alive pings gracefully.