Use intermediate env vars for Pulumi passphrases #595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses security concern where secrets were directly interpolated in run commands. Following GitHub's security best practices, secrets are now passed through intermediate environment variables before being written to files. Changes: - deploy.yml: Fixed both staging and production deployments - cancel-pulumi-lock.yml: Fixed both staging and production lock cancellation This maintains compatibility with the existing Makefile workflow while reducing the risk of accidental secret disclosure.
|
To be clear: this is not a vulnerability, just improving to match security best practice and increase defence-in-depth :) |
rdimitrov
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the security concern where secrets were directly interpolated in GitHub Actions run commands across multiple workflows.
Following GitHub's security best practices, secrets are now passed through intermediate environment variables (matching the secret names:
PULUMI_STAGING_PASSPHRASEandPULUMI_PROD_PASSPHRASE) before being written to files.Changes
deploy.yml:
cancel-pulumi-lock.yml:
Benefits
This approach:
The key improvement is that
${{ secrets.X }}is no longer expanded directly in the run commands, reducing the risk of accidental disclosure if GitHub's masking fails or is bypassed.