Add support for Google Artifact Registry (GAR) #692
Merged
+258
−803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domdomegg
reviewed
Oct 23, 2025
| name: "Docker Hub should be allowed", | ||
| identifier: "docker.io/test/image:latest", | ||
| // Will fail on image not found, but registry should be accepted | ||
| expectError: true, |
There was a problem hiding this comment.
Can we find images that do work? So we can be more certain the tests are working properly.
domdomegg
requested changes
Oct 23, 2025
rdimitrov
force-pushed
the
allow-google-artifact-registry
branch
4 times, most recently
from
0c5d736 to
ae78b7b
Compare
domdomegg
previously approved these changes
Oct 27, 2025
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
rdimitrov
force-pushed
the
allow-google-artifact-registry
branch
from
31a5740 to
b9fdcac
Compare
|
Had to dismiss the approval so I can rebase and fix the conflict on go.mod |
domdomegg
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The following PR:
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context
Related to #427