SEP-1330: Compatibility with SEP-1034 #1100
Merged
+785
−242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ay return type. See [SEP-1330](modelcontextprotocol/modelcontextprotocol#1330) * In types.ts - add UntitledSingleSelectEnumSchema, TitledSingleSelectEnumSchema, LegacyTitledEnumSchema - add SingleSelectEnumSchema that is a union of these three - add UntitledMultiSelectEnumSchema, TitledMultiSelectEnumSchema - add MultiSelectEnumSchema that is a union of these two - refactor EnumSchemaSchema to be a union of SingleSelectEnumSchema and MultiSelectEnumSchema * In elicitation.test.ts - simplify tests by extracting the duplicated client and server creation and connection into a beforeEach run in the describe for each flow - add positive/negative tests for all enum permutations (single-select, multi-select, titled, untitled, and legacy - "should succeed with valid selection in single-select untitled enum" - "should succeed with valid selection in single-select titled enum" - "should succeed with valid selection in single-select titled legacy enum" - "should succeed with valid selection in multi-select untitled enum" - "should succeed with valid selection in multi-select titled enum" - "should reject invalid selection in single-select untitled enum" - "should reject invalid selection in single-select titled enum" - "should reject invalid selection in single-select titled legacy enum" - "should reject invalid selection in multi-select untitled enum" - "should reject invalid selection in multi-select titled enum"
…pe. See [SEP-1330](modelcontextprotocol/modelcontextprotocol#1330) * In types.ts - Set UntitledMultiSelectEnumSchema and TitledMultiSelectEnumSchema - set default to z.array(z.string()).optional()
…on-for-sep-1330' into update-enum-schema-and-elicitation-for-sep-1330
- removed @ts-expect-error instances
- fix default return types on single-select with titles
- In "should succeed with valid selection in multi-select untitled enum"
- rename prop to colors
* In types.ts
- add string array to ElicitResultSchema
- Replace @ts-expect-error erroneously removed for "pattern" types * In types.ts - follow the pattern of the other primitive types - name the zod schemas with SchemaSchema at the end - export types inferred from enum schemas with just Schema at the end * In spec.types.test.ts - add tests for enum types
commit: |
9 tasks
3 tasks
felixweinberger
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend SEP-1330 by @cliffhall to provide compatibility with SEP-1034.
Original Author: @cliffhall
Original PR: #1077
Motivation and Context
Client-side defaulting of the new enum types.
How Has This Been Tested?
Unit tests
Breaking Changes
None
Types of changes
Checklist
Additional context