fix: improve SSE reconnection behavior #1191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per SEP-1699, the client should only reconnect when the server disconnects BEFORE sending a response (for long-running operations). The previous implementation would reconnect after ANY stream completion when a priming event was received, even when the response was already delivered. This fix tracks whether a response was received and skips reconnection if so. This prevents: 1. Unnecessary network round-trips 2. Race conditions with rapid stream cycling (which caused crashes in consumers like the inspector) Adds test case to verify the correct behavior.
commit: |
Track the reconnection timeout ID and clear it when close() is called. This prevents reconnection attempts after the transport is closed, which was causing "Failed to reconnect SSE stream" errors on disconnect. Adds test case to verify reconnection is cancelled after close().
felixweinberger
force-pushed
the
fweinberger/sep1699-debug
branch
from
37276ea to
3be665f
Compare
pcarleton
approved these changes
Dec 1, 2025
| const message = JSONRPCMessageSchema.parse(JSON.parse(event.data)); | ||
| if (replayMessageId !== undefined && isJSONRPCResponse(message)) { | ||
| message.id = replayMessageId; | ||
| if (isJSONRPCResponse(message)) { |
Member
There was a problem hiding this comment.
i wasn't sure if this would get triggered by notifications etc. but those would be a different schema, so shouldn't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SSE reconnection issues that were causing errors with SEP-1699 usage.
Motivation and Context
When using SSE streaming with SEP-1699 priming events, several issues occurred:
How Has This Been Tested?
Breaking Changes
None
Types of changes
Checklist