fix hanging stdio servers #1200
Merged
+220
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: TomasRup <tomasr@wix.com>
Ensure proper disposal of mock streams to prevent resource leaks and avoid process hangs.
- Make test servers use ts and init them with tsx - Add test to check if hanging server actually gets killed
commit: |
Contributor
Author
|
fixes #271 |
felixweinberger
requested changes
Dec 1, 2025
Contributor
felixweinberger
left a comment
felixweinberger
left a comment
There was a problem hiding this comment.
LGTM, though would be a great opportunity to match the behavior to the spec more precisely while we're in this space
Contributor
Author
|
Oooh matching python now. |
felixweinberger
approved these changes
Dec 1, 2025
|
|
||
| if (processToClose.exitCode === null) { | ||
| try { | ||
| processToClose.kill('SIGTERM'); |
This was referenced Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thanks to #818 and @johnnyasantoss for the pr. Adding to your work here.
Also adds a fixtures folder.
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context