diff --git a/.changeset/related-zero-debounce.md b/.changeset/related-zero-debounce.md new file mode 100644 index 0000000000..b155a6863a --- /dev/null +++ b/.changeset/related-zero-debounce.md @@ -0,0 +1,5 @@ +--- +'@modelcontextprotocol/core': patch +--- + +Treat numeric related request ID `0` as present when deciding whether a notification can be debounced. diff --git a/packages/core/src/shared/protocol.ts b/packages/core/src/shared/protocol.ts index 361bd6fc7c..3e33d2b37c 100644 --- a/packages/core/src/shared/protocol.ts +++ b/packages/core/src/shared/protocol.ts @@ -1009,8 +1009,9 @@ export abstract class Protocol { const debouncedMethods = this._options?.debouncedNotificationMethods ?? []; // A notification can only be debounced if it's in the list AND it's "simple" // (i.e., has no parameters and no related request ID or related task that could be lost). + const hasRelatedRequestId = options?.relatedRequestId !== undefined; const canDebounce = - debouncedMethods.includes(notification.method) && !notification.params && !options?.relatedRequestId && !options?.relatedTask; + debouncedMethods.includes(notification.method) && !notification.params && !hasRelatedRequestId && !options?.relatedTask; if (canDebounce) { // If a notification of this type is already scheduled, do nothing. diff --git a/packages/core/test/shared/protocol.test.ts b/packages/core/test/shared/protocol.test.ts index 619e09376a..61f73deeb9 100644 --- a/packages/core/test/shared/protocol.test.ts +++ b/packages/core/test/shared/protocol.test.ts @@ -768,6 +768,20 @@ describe('protocol tests', () => { expect(sendSpy).toHaveBeenCalledWith(expect.any(Object), { relatedRequestId: 'req-2' }); }); + it('should NOT debounce a notification that has relatedRequestId 0', async () => { + // ARRANGE + protocol = new TestProtocolImpl({ debouncedNotificationMethods: ['test/debounced_with_zero_id'] }); + await protocol.connect(transport); + + // ACT + await protocol.notification({ method: 'test/debounced_with_zero_id' }, { relatedRequestId: 0 }); + await protocol.notification({ method: 'test/debounced_with_zero_id' }, { relatedRequestId: 0 }); + + // ASSERT + expect(sendSpy).toHaveBeenCalledTimes(2); + expect(sendSpy).toHaveBeenCalledWith(expect.any(Object), { relatedRequestId: 0 }); + }); + it('should clear pending debounced notifications on connection close', async () => { // ARRANGE protocol = new TestProtocolImpl({ debouncedNotificationMethods: ['test/debounced'] });