Skip to content

Conversation

@yuwzho
Copy link
Contributor

@yuwzho yuwzho commented Sep 16, 2025

The sample code has a problem to construct the URL object again. This is already construct at Line 1225

Motivation and Context

The existing code snippet is not work

How Has This Been Tested?

Tested by creating the client

Breaking Changes

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

The baseUrl is type of URL at Line 1225.
@mattzcarey mattzcarey requested a review from a team as a code owner November 28, 2025 10:38
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 28, 2025

Open in StackBlitz

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/sdk@944

commit: 5e278b1

Copy link
Contributor

@mattzcarey mattzcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@felixweinberger felixweinberger merged commit ec33e3f into modelcontextprotocol:main Nov 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants