Dialog defaults #2888
Merged
Dialog defaults #2888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikt-ma
requested changes
Mar 15, 2021
There was a problem hiding this comment.
In addition to minor change requested on wording, there was the question of how to express the behavior of not having specified loadSelector or saveSelector . Without this, we miss the part that comes from #2852.
henrikt-ma
reviewed
Mar 16, 2021
henrikt-ma
reviewed
Mar 16, 2021
|
I believe the suggestions are now handled. |
henrikt-ma
requested changes
Mar 29, 2021
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2854