New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update start value in Modelica.Fluid.Examples.InverseParameterization #2063

Closed
modelica-trac-importer opened this Issue Jan 15, 2017 · 5 comments

Comments

Projects
None yet
4 participants
@modelica-trac-importer

Reported by agnes.ramle on 16 Sep 2016 12:48 UTC
Would it be possible to update pump.m_flow_start to not start at zero flow. The current 0 flow causes pump.port_b.m_flow to be on the wrong branch in the actualStream operator in

 pump.Hb_flow = pump.port_a.m_flow * actualStream(pump.port_a.h_outflow) + pump.port_b.m_flow * actualStream(pump.port_b.h_outflow);

The suggestion is to set pump.m_flow_start=0.5.


Migrated-From: https://trac.modelica.org/Modelica/ticket/2063

@modelica-trac-importer

This comment has been minimized.

Show comment
Hide comment
@modelica-trac-importer

modelica-trac-importer Jan 15, 2017

Comment by hansolsson on 19 Sep 2016 12:48 UTC
Changing the defaults in such generic models does not seem like a good solution, and might change existing results.

However, I can see a numeric issue with using the definition of actualStream at that point - in particular that we select inconsistent branches for the two actualStream.

Comment by hansolsson on 19 Sep 2016 12:48 UTC
Changing the defaults in such generic models does not seem like a good solution, and might change existing results.

However, I can see a numeric issue with using the definition of actualStream at that point - in particular that we select inconsistent branches for the two actualStream.

@chria

This comment has been minimized.

Show comment
Hide comment
@chria

chria May 21, 2018

Contributor

Would it be possible to update the start value in the example instead? See the attachment (sorry for it not being a pull request)
updateStartInverseParameterization.txt

Contributor

chria commented May 21, 2018

Would it be possible to update the start value in the example instead? See the attachment (sorry for it not being a pull request)
updateStartInverseParameterization.txt

@beutlich beutlich added this to the MSL3.2.3 milestone May 22, 2018

@beutlich

This comment has been minimized.

Show comment
Hide comment
@beutlich

beutlich May 22, 2018

Member

@chria Can you please check if 62ae893 already fixes the issue on your side.

Member

beutlich commented May 22, 2018

@chria Can you please check if 62ae893 already fixes the issue on your side.

@chria

This comment has been minimized.

Show comment
Hide comment
@chria

chria May 23, 2018

Contributor

@beutlich I've checked and it fixes the issue, thanks!

Contributor

chria commented May 23, 2018

@beutlich I've checked and it fixes the issue, thanks!

@beutlich

This comment has been minimized.

Show comment
Hide comment
@beutlich

beutlich May 23, 2018

Member

Thanks for confirmation.

Resolved by 62ae893 in master.

Member

beutlich commented May 23, 2018

Thanks for confirmation.

Resolved by 62ae893 in master.

@beutlich beutlich closed this May 23, 2018

@beutlich beutlich added the example label May 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment