Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modelica.Mechanics.MultiBody.Joints.Prismatic - s_offset - constant vs parameter #2465

Closed
NateHorn opened this issue Feb 12, 2018 · 6 comments
Assignees
Labels
bug Critical/severe issue L: Mechanics.MultiBody Issue addresses Modelica.Mechanics.MultiBody
Milestone

Comments

@NateHorn
Copy link

Is there any reason that s_offset is a constant rather than a parameter? Thanks!

@beutlich beutlich added question Unexplained or undecided issue L: Mechanics.MultiBody Issue addresses Modelica.Mechanics.MultiBody labels Feb 12, 2018
@FrenkelJ
Copy link

By the way the Evaluate Annotation is only specified for a component declared with the prefix parameter. See Spec. 18.3 Evaluate.

@beutlich beutlich added bug Critical/severe issue and removed question Unexplained or undecided issue labels Feb 13, 2018
@beutlich beutlich added this to the MSL3.2.3 milestone Feb 13, 2018
@beutlich
Copy link
Member

It looks like a bug introduced by c025e05. Note that s_offset is a proper parameter (without Evaluate annotation) in the other aggregate joints with prismatic degree of freedom.

@MartinOtter
Copy link
Member

No, this is not a bug, but a feature. The reason is that I wanted to get rid of offset, to make joints simpler. For backwards compatibility reasons, "offset" was not removed but kept. Via "constant" it was, however, removed from the parameter menu. Note, a constant "phi_offset" is also present in the Revolute joint (for the same reasons).

@beutlich
Copy link
Member

beutlich commented Feb 13, 2018

  • Still it would be wise to remove the Evaluate annotation for MSL 3.2.3.
  • Please file a new ticket with milestone MSL_next-MAJOR-version to remove the superfluous s_offset constant then.

@beutlich beutlich reopened this Feb 13, 2018
@tobolar
Copy link
Contributor

tobolar commented Feb 19, 2018

Another option is to let s_offset be a parameter with annotation (Dialog(enable=false)). This enables a user to still see there is such a parameter with some value which influences the model behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Critical/severe issue L: Mechanics.MultiBody Issue addresses Modelica.Mechanics.MultiBody
Projects
None yet
Development

No branches or pull requests

5 participants