Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing component descriptions in example ShowTransferFunction #2761

Closed
beutlich opened this issue Oct 29, 2018 · 4 comments · Fixed by #2767
Closed

Missing component descriptions in example ShowTransferFunction #2761

beutlich opened this issue Oct 29, 2018 · 4 comments · Fixed by #2767
Assignees
@AHaumer
Labels
example Issue only addresses example(s) L: Complex* Issue addresses Complex, Modelica.ComplexBlocks or Modelica.ComplexMath V: 3.2.2 Issue originates in MSL v3.2.2 (and is not present in earlier releases)
Milestone
MSL3.2.3

Comments

@beutlich
Copy link
Member

Parameters a, b, d, wMax, wMin and variables dB, lg_w and phi miss a descriptive string.

See also #2166 and #1850.
@beutlich beutlich added L: Complex* Issue addresses Complex, Modelica.ComplexBlocks or Modelica.ComplexMath V: 3.2.2 Issue originates in MSL v3.2.2 (and is not present in earlier releases) example Issue only addresses example(s) labels Oct 29, 2018
@beutlich beutlich added this to the MSL3.2.3 milestone Oct 29, 2018
@AHaumer
Copy link
Contributor

AHaumer commented Nov 5, 2018

d: damping coefficient
b: numerator polynomial coefficients of transfer function
a: denominator polynomial coefficients of transfer function
wMin: lower bound for frequency sweep
wMax: upper bound for frequency sweep
lg_w: logarithm of frequency
dB: absolute of transfer function in decibel
phi: argument of transfer function

beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue Nov 5, 2018
@beutlich
refs modelica#2761: Add component descriptions
db7ecbf
@beutlich beutlich mentioned this issue Nov 5, 2018
Merged
@beutlich
Copy link
Member Author

beutlich commented Nov 5, 2018

Thanks.

dB: absolute of transfer function in decibel

Modified to magnitude in #2767. Please review.

@tobolar
Copy link
Contributor

tobolar commented Nov 6, 2018

Please mark this also in #2636, if finished!

beutlich added a commit that referenced this issue Nov 8, 2018
@beutlich
refs #2761: Add component descriptions (#2767)
3dbfde8
@beutlich
Copy link
Member Author

beutlich commented Nov 8, 2018

Please mark this also in #2636, if finished!

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AHaumer AHaumer

Labels
example Issue only addresses example(s) L: Complex* Issue addresses Complex, Modelica.ComplexBlocks or Modelica.ComplexMath V: 3.2.2 Issue originates in MSL v3.2.2 (and is not present in earlier releases)
Projects
None yet
Milestone
MSL3.2.3
3 participants
@AHaumer @tobolar @beutlich