Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why PowerLoss in LossyGearDemos #2934

Open
HansOlsson opened this issue May 14, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@HansOlsson
Copy link
Contributor

commented May 14, 2019

Modelica.Mechanics.Rotational.Examples.LossyGearDemo{1,2} contain

SI.Power PowerLoss=gear.flange_a.tau*der(gear.flange_a.phi) + gear.flange_b.tau
      *der(gear.flange_b.phi) "Power lost in the gear";

This is already computed as gear.lossPower so it seems unnecessary to duplicate the computation, and it is even not clear if it should be at the top-level, i.e. whether we could remove the top-level variable and just keep gear.lossPower.

In addition for Modelica.Mechanics.Rotational.Examples.LossyGearDemo2 it is misleading as the total PowerLoss should add the losses from both gear and bearing.

@tobolar

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

I don't know the backgroud of implementing that variable. I can imagine this is some leftover from times before having gear.lossPower. So to me it is fine to delete it. The documentation must be changed accordingly.

Btw: The decription of PowerLoss in LossyGearDemo2 says "Power lost in the gear". But the interpretation of "gear" is ambivalent.

@MartinOtter Any comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.