Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-check should verify derivative attribute #24

Closed
Maplesoft-fmigroup opened this issue Nov 28, 2018 · 1 comment
Assignees

Comments

@Maplesoft-fmigroup
Copy link
Contributor

@Maplesoft-fmigroup Maplesoft-fmigroup commented Nov 28, 2018

On page 54 of FMI2.0 spec it says:

The state derivatives of an FMU are listed under element . All ScalarVariables listed in this element must have attribute derivative (in order that the continuous-time states are uniquely defined).

However, there are FMUs in the repository that fail to provide this information. For example:
https://github.com/modelica/fmi-cross-check/blob/master/fmus/2.0/cs/win64/MWorks/2016/MixtureGases/MixtureGases.fmu

has four Derivatives declared in the ModelStructure but there are no ScalarVariables with the attribute. This makes the FMU invalid and thus it should not pass the cross checker.

@t-sommer t-sommer transferred this issue from modelica/fmi-standard Nov 29, 2018
@t-sommer t-sommer self-assigned this Nov 29, 2018
@t-sommer t-sommer changed the title Cross checker should verify derivative attribute Cross-check should verify derivative attribute Nov 29, 2018
@t-sommer

This comment has been minimized.

Copy link
Collaborator

@t-sommer t-sommer commented Nov 29, 2018

The following FMUs do not define derivatives for all continuous state variables as required by the rule cited above:

/fmus/2.0/me/win64/MWorks/2016/fullRobot/fullRobot.fmu
/fmus/2.0/me/win64/MWorks/2016/CoupledClutches/CoupledClutches.fmu
/fmus/2.0/me/win64/MWorks/2016/Rectifier/Rectifier.fmu
/fmus/2.0/me/win64/MWorks/2016/MixtureGases/MixtureGases.fmu
/fmus/2.0/me/win64/MWorks/2016/ControlledTemperature/ControlledTemperature.fmu
/fmus/2.0/me/win64/MWorks/2016/BouncingBall/BouncingBall.fmu
/fmus/2.0/me/win64/Easy5/2017.1/PneumaticActuator/PneumaticActuator.fmu
/fmus/2.0/me/win64/Easy5/2017.1/Linear_Pos/Linear_Pos.fmu
/fmus/2.0/me/win64/Easy5/2017.1/VanDerPol/VanDerPol.fmu
/fmus/2.0/me/win32/MWorks/2016/fullRobot/fullRobot.fmu
/fmus/2.0/me/win32/MWorks/2016/CoupledClutches/CoupledClutches.fmu
/fmus/2.0/me/win32/MWorks/2016/Rectifier/Rectifier.fmu
/fmus/2.0/me/win32/MWorks/2016/MixtureGases/MixtureGases.fmu
/fmus/2.0/me/win32/MWorks/2016/ControlledTemperature/ControlledTemperature.fmu
/fmus/2.0/me/win32/MWorks/2016/BouncingBall/BouncingBall.fmu
t-sommer added a commit that referenced this issue Nov 29, 2018
@t-sommer t-sommer closed this Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.