New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numeric variable types (FCP-017) #481

Open
t-sommer opened this Issue Nov 6, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@t-sommer
Collaborator

t-sommer commented Nov 6, 2018

@t-sommer t-sommer added the FCP label Nov 6, 2018

@t-sommer t-sommer added this to the FMI 3.0 milestone Nov 6, 2018

@t-sommer t-sommer self-assigned this Nov 6, 2018

@pmai

This comment has been minimized.

Collaborator

pmai commented Nov 6, 2018

Shall I create a corresponding feature branch in fmi-standard with the commits from fmi3-numeric-variable-types?

@t-sommer

This comment has been minimized.

Collaborator

t-sommer commented Nov 6, 2018

I've created the branch feature/numeric-variable-types (without the prefix since all new features go into the next version anyways). I'll make a PR with an updated version of my proposal.

@chrbertsch

This comment has been minimized.

Collaborator

chrbertsch commented Nov 6, 2018

I had created a dummy FCP-16 for this topic https://github.com/modelica/fmi-design/tree/master/FMI_ChangeProposals/FCP_016_Data_Types
Now a new FCP-017 has been created:
https://github.com/modelica/fmi-design/tree/master/FMI_ChangeProposals/FCP_017_Numeric_Variable_Types
Now we should merge them and delete one of them.

@t-sommer

This comment has been minimized.

Collaborator

t-sommer commented Nov 6, 2018

@chrbertsch I will go through the document and merge it with FCP-017. Thanks for the hint!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment