Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable attributes "min", "max" and "nominal" should be lists #590

Open
t-sommer opened this issue Jul 2, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@t-sommer
Copy link
Collaborator

commented Jul 2, 2019

... like for attribute "start", so a value can be supplied for each index.

@t-sommer t-sommer added the bug label Jul 2, 2019

@t-sommer t-sommer added this to the v3.0 milestone Jul 2, 2019

@otronarp

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

My take on this is that min/max/nominal (as well as all the unit/quantity related attributes) are part of the "type" and I really would like us to restrict arrays to contain one single type.

@t-sommer t-sommer added discussion and removed bug labels Jul 2, 2019

@KarlWernersson

This comment has been minimized.

Copy link
Collaborator

commented Jul 2, 2019

I agree, use scalar if you want to scalarise you array, one of the main things that makes it harder to import "arrays" deduced from structural naming, in FMI 1.0 and 2.0 is that there is no requirement that the types are consistent. This was discussed quite thoroughly during early design of the array proposal and it was decided to restrict types because of this.Another problen lies withdynamic sized arrays, for start values we have explicitly stated that they become invalid if you deviate from the default size. (if I remeber corectly).However min/max are more fundamental model properties and you would need some getMin/max functions for each vector . (we do already have getNominalsOfContinousStates but that is in conjunction with using get/setContinuousStates)

@t-sommer

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 3, 2019

It's fine for me to keep these attributes as scalars. I suggest we add a sentence to the spec that this is intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.