Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniqueness of `Attribute “name” of Annotations with type `fmi2Annotation`. #629

Open
chrbertsch opened this issue Sep 25, 2019 · 2 comments

Comments

@chrbertsch
Copy link
Collaborator

commented Sep 25, 2019

Originally posted by @CThuleHansen in #623 (comment)

On p. 45 regarding VendorAnnotations with type fmi2Annotation it is stated Attribute “name” must be unique with respect to all other elements of the VendorAnnotation list.
But this is not the case on p. 57 for Annotations with type fmi2Annotation.

This is confusing as the types are the same, fmi2Annotation but the invariants are different.

chrbertsch: see comments below

@CThuleHansen

This comment has been minimized.

Copy link

commented Sep 25, 2019

Positing Nick's proposal from previous thread -- listed below. Seems like a fine approach in my view. SO the proposal is to use the naming from p. 45 on p. 57 as well.

On p. 45 regarding VendorAnnotations with type fmi2Annotation it is stated Attribute “name” must be unique with respect to all other elements of the VendorAnnotation list.
But this is not the case on p. 57 for Annotations with type fmi2Annotation.
This is confusing as the types are the same, fmi2Annotation but the invariants are different.

URGENT:
@ALL : I do not know what to do with this. Please comment and come up with a proposal; otherwise this will not be be included in FMI 2.0.1

VDMCheck verifies this, assuming the tool names should be unique in both places. There are no occurrences of a duplicate name in the whole of the FMI Cross Check repository (792 FMUs), so it might be safe to make that the rule?

Originally posted by @nickbattle in #623 (comment)

@chrbertsch chrbertsch added this to the v2.0.1 milestone Sep 28, 2019
@chrbertsch

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 1, 2019

Discussed with @TorstenBlochwitz : wont fix for FMI 2.0.1, not critical

@chrbertsch chrbertsch modified the milestones: v2.0.1, v3.0 Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.