Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update type names in documentation, schema and examples #669

Closed
t-sommer opened this issue Nov 10, 2019 · 3 comments
Closed

Update type names in documentation, schema and examples #669

t-sommer opened this issue Nov 10, 2019 · 3 comments
Assignees
Labels
Milestone

Comments

@t-sommer
Copy link
Collaborator

@t-sommer t-sommer commented Nov 10, 2019

The old FMI 2.0 type names (e.g. "Real" and "Integer") still appear in the documentation, XSDs and code examples. They should be update to match the new definitions in fmi3PlatformTypes.h.

I suggest to use fmi3Float* and fmi3Int* instead of fmi3Real and fmi3Integer to reflect the added 32-bit and signed / unsigned integer types.

@chrbertsch

This comment has been minimized.

Copy link
Collaborator

@chrbertsch chrbertsch commented Feb 24, 2020

We shall not close this ticket when merging PR 799 as there are still open points, e.g.

  • table entries: there is a lot more that needs fixing in the tables and it is not enough to set {VariableType} here as entries are different for floating point and integer types

grafik

  • pseudo code in SES: This is for AndreasP to fix and should not go into this PR
@andreas-junghanns

This comment has been minimized.

Copy link
Contributor

@andreas-junghanns andreas-junghanns commented Feb 24, 2020

These are different issues with a different focus, I think.
The tables need a general makeover.
The pseudo-code needs more than a quick fix and other issues need to be fixed there too.
Therefore: In the general text, all is done.
Any other issue goes to other tickets, if not already open (table fixes should already be listed).
Therefore, I strongly suggest to close this so that we do not get lost in endless ticket descriptions (rather open a new ticket with a reference to here but a full description of the remaining issues there)

andreas-junghanns added a commit that referenced this issue Feb 25, 2020
@chrbertsch

This comment has been minimized.

Copy link
Collaborator

@chrbertsch chrbertsch commented Feb 25, 2020

Closing as #799 was merged

@chrbertsch chrbertsch closed this Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.