Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table cells show non-normative texts wrong #690

Closed
andreas-junghanns opened this issue Dec 8, 2019 · 5 comments
Closed

table cells show non-normative texts wrong #690

andreas-junghanns opened this issue Dec 8, 2019 · 5 comments
Assignees
Labels
Milestone

Comments

@andreas-junghanns
Copy link
Contributor

@andreas-junghanns andreas-junghanns commented Dec 8, 2019

Inside table cells, the [xx] markings fail and produce:

[ Example: <Variable name=“spD" valueReference="126" causality=“structuralParameter" variability=“fixed"> ]

@t-sommer

This comment has been minimized.

Copy link
Collaborator

@t-sommer t-sommer commented Dec 9, 2019

You can try this:

_[Example:_

[source, xml]
----
<Int32 name="spD" valueReference="126" causality="structuralParameter" variability="fixed" start="3">
  <!-- no Dimension elements allowed -->
</Int32>
----

_]_

However XML should be included from a modelDescription.xml, so it gets validated in CI. The above example is not compliant with the current schema.

@chrbertsch

This comment has been minimized.

Copy link
Collaborator

@chrbertsch chrbertsch commented Dec 13, 2019

Regular design meeting:

Andreas J: We should add to the contribution guidelines: do not add C- or XML-codes outside .c or .xml files that can be validated.

t-sommer added a commit to t-sommer/fmi-standard that referenced this issue Dec 13, 2019
t-sommer added a commit that referenced this issue Feb 7, 2020
…#694)

see #690, #691
@chrbertsch chrbertsch added this to the v3.0 milestone Feb 11, 2020
@t-sommer

This comment has been minimized.

Copy link
Collaborator

@t-sommer t-sommer commented Feb 21, 2020

@andreas-junghanns, can you check if the problem still exists?

@andreas-junghanns

This comment has been minimized.

Copy link
Contributor Author

@andreas-junghanns andreas-junghanns commented Feb 22, 2020

Regular design meeting:

Andreas J: We should add to the contribution guidelines: do not add C- or XML-codes outside .c or .xml files that can be validated.
This is now done in the CONTRIBUTING.adoc

@andreas-junghanns

This comment has been minimized.

Copy link
Contributor Author

@andreas-junghanns andreas-junghanns commented Feb 22, 2020

I checked the non-normative texts in table cells and all look ok. Not sure what I saw. All well, closing as invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.