Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check non normative text on pure discrete-time FMUs #704

Open
chrbertsch opened this issue Jan 12, 2020 · 1 comment
Open

Check non normative text on pure discrete-time FMUs #704

chrbertsch opened this issue Jan 12, 2020 · 1 comment
Assignees
Labels
Milestone

Comments

@chrbertsch
Copy link
Collaborator

@chrbertsch chrbertsch commented Jan 12, 2020

In FMI 2.0.1 we have the following non-normative text in remark 4 or section 3.1:

This is an optional optimization for the master, the FMU must support all functions that are required for a continuous time FMU and should run in a master that treats it as such. If a pure discrete time FMU has state events and uses event indicators, it has to enter continuousTimeMode to evaluate these. In fact, it is no longer a Pure Discrete time FMU but this was not clearly defined in 2.0 so this clarification is needed for 2.0.1]

Check that in FMI 3.0 we have a correction in the normative text and adapt or remove the normative text

@chrbertsch chrbertsch added this to the v3.0 milestone Feb 11, 2020
@t-sommer t-sommer added the task label Feb 21, 2020
@chrbertsch chrbertsch changed the title Check non normative text on pure discrete FMUs Check non normative text on pure discrete-time FMUs Feb 21, 2020
@chrbertsch

This comment has been minimized.

Copy link
Collaborator Author

@chrbertsch chrbertsch commented Feb 21, 2020

(The original issue was #409)

I consider it problematic that "pure discrete time FMU" seem to be only defined in non-normative remarks:

  • remark 2 of 3.1.2, which deals with "discrete-time FMUs" without the "pure". Is this the same?
  • remark 4. of 3.1.2 grafik

but then we refer to this definition in normative text (footnote of the table at the end of 3.2.3
grafik

I see the following alternatives for FMI 3.0:

  • Correct the definition in the remark 4 to "If an FMU has only discrete-time equations (and no variables with variability = continuous and no state events and event indicators), ..." But still this then should be move to a normative text part
  • get completely rid of the definition of "pure discrete-time FMUs", as in FMI 3.0 there are new ways to express discrete-time systems like clocks and the new FMU type SES

I would favour the second option. Or do I miss something? Or other suggestions?

@chrbertsch chrbertsch added Berlin2020 and removed task labels Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.