Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logMessage #vref# behaviour with aliases #732

Closed
nickbattle opened this issue Feb 4, 2020 · 2 comments
Closed

logMessage #vref# behaviour with aliases #732

nickbattle opened this issue Feb 4, 2020 · 2 comments
Assignees
Labels
Milestone

Comments

@nickbattle
Copy link
Collaborator

@nickbattle nickbattle commented Feb 4, 2020

Section 2.1.5 describes the expansion of #<valueReference># values into the name of the referenced variable in log messages. But if the value reference has an alias-set of variables, which variable's name is substituted? Is one is chosen arbitrarily or is it maybe an error to attempt this?

(I think this is also a question with FMI2 - the fmi-sdk seems to pick the first SV it finds with the right vref)

@pmai

This comment has been minimized.

Copy link
Collaborator

@pmai pmai commented Feb 4, 2020

As you say, the importing implementation has no way of knowing which of multiple variable names to choose here, as discussed in #435, esp. my comment #435 (comment). So it will pick an arbitrary name.

It was decided that the ability for FMU exporters to not have to place knowledge of variable names into exported code was deemed more important than removing this complex mechanism with its draw backs. As such I think the rationale for this decision and the consequences should probably be pointed out in non-normative text, A pull request would probably be appreciated.

@chrbertsch

This comment has been minimized.

Copy link
Collaborator

@chrbertsch chrbertsch commented Feb 7, 2020

Regular design webmeeting:
A discussion has started if "alias variables" should refer to a variable that is no not an alias. This could then also resolve this issue. @klausschuch plans to create a proposals.

@chrbertsch chrbertsch added this to the v3.0 milestone Feb 11, 2020
@t-sommer t-sommer added the task label Feb 21, 2020
andreas-junghanns pushed a commit to andreas-junghanns/fmi-standard that referenced this issue Feb 21, 2020
t-sommer pushed a commit that referenced this issue Feb 22, 2020
when vr is pointing to an alias set of variables

see  #732
@t-sommer t-sommer closed this Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.