Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use enum in header files for fmi3Clock and fmi3Byte #805

Closed
masoud-najafi opened this issue Feb 25, 2020 · 2 comments
Closed

use enum in header files for fmi3Clock and fmi3Byte #805

masoud-najafi opened this issue Feb 25, 2020 · 2 comments
Assignees
Milestone

Comments

@masoud-najafi
Copy link
Collaborator

@masoud-najafi masoud-najafi commented Feb 25, 2020

Instead of defining
typedef char fmi3Byte;
typedef int fmi3Clock ;
in the header files, it would be more efficient if we define:

typedef enum {fmi3False=0 , fmi3True } fmi3Byte;
typedef enum {fmi3ClockInactive =0 , fmi3ClockActive} fmi3Clock ;

This has the advantage that the comiler can check the values.

@chrbertsch

This comment has been minimized.

Copy link
Collaborator

@chrbertsch chrbertsch commented Feb 25, 2020

@pmai : Could you please comment this?

@chrbertsch chrbertsch added this to the v3.0 milestone Feb 27, 2020
@andreas-junghanns

This comment has been minimized.

Copy link
Contributor

@andreas-junghanns andreas-junghanns commented Mar 27, 2020

web design meeting: We cannot see the benefit to introduce these new enum types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.