[bugfix] fix agent_template

[Jintao-Huang]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @Jintao-Huang, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug within the _add_dynamic_eos function in the agent template system. The changes primarily focus on improving the robustness of list iteration and boundary condition handling. By adjusting the loop range and adding explicit index checks, the fix prevents potential out-of-bounds errors and ensures accurate processing of end-of-sequence markers within the labels array.

Highlights

• Loop Iteration Correction: The iteration range in the _add_dynamic_eos function has been extended from range(1, len(labels)) to range(1, len(labels) + 1) to ensure all relevant elements, including the last one, are considered.
• Index Bounds Check: An explicit bounds check i < len(labels) was added before accessing labels[i] to prevent potential IndexError when i reaches the end of the list.
• End-of-Sequence Handling: The logic for detecting the end of a sequence of -100 values has been refined to correctly handle cases where such a sequence extends to the very end of the labels list, by checking i == len(labels).

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes a bug in _add_dynamic_eos where unlabeled sequences at the end of the labels list were not handled. The change correctly extends the loop range and adds necessary boundary checks to prevent index errors. The fix is correct. I've added one suggestion to improve the readability and maintainability of the logic within the loop.

[gemini-code-assist]

Since this if condition (labels[i - 1] == -100) is mutually exclusive with the condition in the if statement on line 984 (labels[i - 1] >= 0), using elif here would make the logic clearer and improve maintainability by explicitly showing the relationship between the two checks. This also yields a minor performance improvement as the second condition won't be checked if the first one is true.

Suggested change

	if start > 0 and labels[i - 1] == -100 and (i == len(labels) or labels[i] >= 0):
	elif start > 0 and labels[i - 1] == -100 and (i == len(labels) or labels[i] >= 0):