Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ET-741, PRMTR-206, TCMN-47: Promoter Listeners improvements #1311

Closed
wants to merge 25 commits into from

Conversation

@mitogh
Copy link
Member

mitogh commented Mar 4, 2020

Ticket ET-741
Ticket PRMTR-206
Ticket: TCMN-47

bordoni and others added 5 commits Feb 20, 2020
…ease/B20.03
…om being called again.
If a WP_Post is send back make sure to use the ID of the post.

Ticket: [ET-741]
@mitogh mitogh self-assigned this Mar 4, 2020
@mitogh mitogh changed the title Spotfix/et 741 promoter listeners Promoter Listeners improvements Mar 4, 2020
@mitogh mitogh changed the title Promoter Listeners improvements ET-741, PRMTR-206, TCMN-47: Promoter Listeners improvements Mar 4, 2020
…k was not in place
@bordoni bordoni changed the base branch from master to release/B20.03 Mar 5, 2020
@lucatume

This comment has been minimized.

Copy link
Contributor

lucatume commented Mar 5, 2020

@mitogh there's a lot of commit noise in there, was this branch forked off release/20.03?

@mitogh

This comment has been minimized.

Copy link
Member Author

mitogh commented Mar 5, 2020

Was based from master let me do the Merge dance to cleanup this 💃

@mitogh

This comment has been minimized.

Copy link
Member Author

mitogh commented Mar 5, 2020

This PR requires: #1313

@mitogh mitogh removed the hold label Mar 5, 2020
jesseeproductions and others added 6 commits Mar 5, 2020
# Conflicts:
#	package.json
#	readme.txt
#	src/Tribe/Main.php
#	tribe-common.php
mitogh and others added 8 commits Mar 7, 2020
There are several benefits in doing the change like:

- Use of constant to define the value `WP_TEMP_DIR`
- `get_temp_dir` fallback to `sys_get_temp_dir` when the function exists and check the function is present on the system
- Validations of the different directories (is writtable) before returning the value

In order to provide better support with native WordPress functions,
Remove .mo files from repo as well as .min.js files
…gia-state

Added context to Georgia
Fix/ecp 345 check doing filter
Replace `sys_get_temp_dir` with native `get_temp_dir`
Copy link
Contributor

sc0ttkclark left a comment

Needs changelog, but looks good!

@mitogh

This comment has been minimized.

Copy link
Member Author

mitogh commented Mar 9, 2020

Hey @sc0ttkclark are you planning to do a release with ET for common? if so we can include this into that branch instead.

Thanks.

@sc0ttkclark

This comment has been minimized.

Copy link
Contributor

sc0ttkclark commented Mar 9, 2020

There are no common changes as of yet for G20.03

@mitogh mitogh removed the needs changelog label Mar 9, 2020
@mitogh mitogh requested a review from sc0ttkclark Mar 9, 2020
mitogh added 2 commits Mar 9, 2020
ET-741, PRMTR-206, TCMN-47 #resolve
@sc0ttkclark sc0ttkclark changed the base branch from release/B20.03 to release/G20.03 Mar 10, 2020
@mitogh mitogh closed this Mar 10, 2020
@mitogh mitogh deleted the spotfix/ET-741-promoter-listeners branch Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.